Community Forums

1. 

   Ian Nalepa
   Member
   Posted 11 years ago

   I thought I'd start a new thread for this based on comments in the following threads:

   http://mediacorecommunity.org/community/topic/youtube-channel-import-removed

   http://mediacorecommunity.org/community/topic/no-suitable-players-found-error#post-3639

   In an attempt to switch to the licensed version of the JWPlayer, to remove the watermark, I downloaded and upgraded the built in MediaCore JW with the same version of the licensed player. Both version 5.5 build 1641.

   The licensed player broke in IE8 again even though it's the same build. This made me wonder if the JW code had been altered for the MediaCore version. I did a diff and got the following results.

   
--- /Users/ijn1/Desktop/jwplayer55official.js
+++ /Users/ijn1/Desktop/jwplayer55mediacore.js
@@ -4,7 +4,7 @@

   -jwplayer.version = "5.5.1641 (Licensed version)";
   +jwplayer.version = "5.5.1641";

   @@ -733,7 +733,7 @@

   - var j = e.utils.selectors("source", n);
   + var j = e.utils.selectors("source", n.parentNode);

   @@ -1027,7 +1027,7 @@

   - var d = "http://lp.longtailvideo.com";
   + var d = "http://plugins.longtailvideo.com";

   @@ -2396,8 +2396,8 @@

   - file: "",
   - link: "",
   + file: "logo.png",
   + link: "http://www.longtailvideo.com/players/jw-flv-player/",

   @@ -4285,9 +4285,9 @@

   - prefix: "",
   - file: "",
   - link: "",
   + prefix: "http://l.longtailvideo.com/html5/",
   + file: "logo.png",
   + link: "http://www.longtailvideo.com/players/jw-flv-player/",

   These are the only file differences. Some are obviously for the licensed version... Not sure about the other stuff. I figure it has to be something in this file that's breaking. Going to try adding making the changes to the licensed version.
2. 

   Ian Nalepa
   Member
   Posted 11 years ago

   I tracked the issue with this down to the following chunk of code.

   This is from the MediaCore jwplayer.js:
   
var j = e.utils.selectors("source", n.parentNode);


   It's this in the downloaded licensed version:
   
var j = e.utils.selectors("source", n);


   Simply adding the ".parentNode" fixes the licensed version, however, I have no idea what this does. Maybe this was a change made early in the development of MediaCore... Anyway, now going to see if this same change fixes newer versions of JW Player as well.
3. 

   Ian Nalepa
   Member
   Posted 11 years ago

   Yep, adding ".parentNode" as described above fixes the latest JW Player 5.10 build 2295 in IE7 and IE8.

   YAY!!!!!!!!!!!!!!!

   Submitted patch pull request. Combined JW update with code mod. Let me know if the two should be separated.
4. 

   Felix Schwarz
   MediaDrop developer
   Posted 11 years ago

   Thank you very much for debugging the issue. That set my on the right track to fix the issue:

   git log mediacoure/public/scripts/third-party/jw_player/jwplayer_debug.js

   Now there are a couple of commits but 'git diff' reveals the most interesting one:
   commit 6977277d369f4360710875d7ebb348b390b40b4d
Author: Nathan Wright <nathan@simplestation.com>
Date: Fri Mar 11 14:05:17 2011 -0800

   Apply a custom hack to JWPlayer to fix <source> tag parsing in IE8. Closes #84

   As I'd liked to have the fixes separate I committed them myself (because it makes the change easier to find as I showed above). However a big thanks to you for pointing out the cause! Please keep up, looking forward to your next pull request.

   Also I have to admit that I'm not such much as a JW Player person so I'd like to invite you to ping me for new version of JW Player or send bug reports/fixes if you encounter problems.
5. 

   Felix Schwarz
   MediaDrop developer
   Posted 11 years ago

   Two more things:
   Sorry that I didn't put your name in the git commit. I'll make sure you will be named in the release notes!

   It would be great if you could test my changes (just to confirm I didn't mess up).
6. 

   Ian Nalepa
   Member
   Posted 11 years ago

   Thanks for addressing! I may find some other small items that are easy to submit back as pull requests, but please close them or redo them at will. I trust your implementations and descriptions far more than my own.

   Also, please let me know if there's a different way that you'd like to receive minor code change suggestions. Would you rather these be submitted as issues rather than pull requests?

   Will test this as soon as possible.
7. 

   Ian Nalepa
   Member
   Posted 11 years ago

   Everything looks good now with the JW Player in IE7/8.
8. 

   Felix Schwarz
   MediaDrop developer
   Posted 11 years ago

   ijnalepa: Well, your fix was spot on, it was just that I preferred smaller commits.

   Also I'd be glad if you can look after JW Player. MediaCore interfaces with so many different external providers that I can't follow all of them.

   You may submit your improvements however you like. Generally I don't use github's pull request functionality to merge changes (I prefer to do that with git on the command line so I know exactly what happens) but I'll act on pull requests for sure.

   You can also use the developer's mailing list or the forum to suggest changes/contribute fixes.

RSS feed for this topic

Reply

You must log in to post.